andygrove commented on code in PR #250:
URL: https://github.com/apache/datafusion-comet/pull/250#discussion_r1594463470
##########
core/src/execution/datafusion/planner.rs:
##########
@@ -1039,6 +1039,21 @@ impl PhysicalPlanner {
.collect();
let full_schema = Arc::new(Schema::new(all_fields));
+ // Because we cast dictionary array to array in scan operator,
+ // we need to change dictionary type to data type for join filter
expression.
+ let fields: Vec<_> = full_schema
+ .fields()
+ .iter()
+ .map(|f| match f.data_type() {
+ DataType::Dictionary(_, val_type) => {
+ Arc::new(Field::new(f.name(),
val_type.as_ref().clone(), true))
Review Comment:
Should we preserve the fields nullable flag here?
```suggestion
Arc::new(Field::new(f.name(),
val_type.as_ref().clone(), f.is_nullable()))
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
