MohamedAbdeen21 commented on PR #10396:
URL: https://github.com/apache/datafusion/pull/10396#issuecomment-2096811278
This seems to be a major conflict with #10333
> The source of the issue is that an idenfifier needs to represent an
expression subtreee and the newly chosen "stringified expr" as identifier
doesn't seem to fulfill that purpose. E.g. an identifier shouldn't belong to 2
different expressions
I agree that an identifier shouldn't belong to 2 different expressions, but
why does it have to represent a subtree? The expr IS the subtree itself. If we
use an identifier like `#{expr}` that should be good enough.
> And actually it turned out that the reasons are already explained in the
comments
AFAIK, we only need the identifier to be unique (no collision) for
correctness, I don't see why we require the other traits.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
