peter-toth commented on PR #10396:
URL: https://github.com/apache/datafusion/pull/10396#issuecomment-2096888856
> But the example you mention with a + b. Doesn't that go away if you fix
the side note you mentioned?
>
> `col("a + b")` should be interpreted as `table."a + b"` and not `test.a +
test.b`, meaning that `expr` would never collide in the map, right or am I
missing something?
There are multiple questions here and I don't have the answers for.
- Can we fix the string representation? Do we always have a table reference
to prefix the columns with?
- Even if the string representation of `Expr`s were fixed, using a `String`s
as a key of the map is not a good choice as building a string represatation
will very likely require traversing the whole expression...
I think the best we can do now is to revert
https://github.com/apache/datafusion/pull/9871 and return to the old chained
string representation. (This PR improves the identifier readability by adding
`{}` around it and `|` as separator of elements.) And then in a follow-up PR
replace the string representation to an alternative identifier like the one I
mentioned in the PR description.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
