jayzhan211 commented on code in PR #10391:
URL: https://github.com/apache/datafusion/pull/10391#discussion_r1591669099
##########
datafusion/expr/src/udaf.rs:
##########
@@ -287,18 +286,23 @@ pub trait AggregateUDFImpl: Debug + Send + Sync {
/// aggregate function was called.
fn accumulator(&self, acc_args: AccumulatorArgs) -> Result<Box<dyn
Accumulator>>;
+ /// Return the fields for the function
+ fn field(&self, _args: FieldArgs) -> Result<Field> {
Review Comment:
`return_type` is part of the information in `field` and `state_field` not
replaceable to `field `
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
