milenkovicm commented on code in PR #10354:
URL: https://github.com/apache/datafusion/pull/10354#discussion_r1592050865
##########
datafusion/expr/src/udaf.rs:
##########
@@ -195,6 +197,21 @@ impl AggregateUDF {
pub fn create_groups_accumulator(&self) -> Result<Box<dyn
GroupsAccumulator>> {
self.inner.create_groups_accumulator()
}
+ /// Do the function rewrite
+ ///
+ /// See [`AggregateUDFImpl::simplify`] for more details.
+ pub fn simplify(
+ &self,
+ args: Vec<Expr>,
Review Comment:
Do we change signature of `pub struct AggregateFunction` moving `args`,
`distinct`, `filter` ... to `AggegateArgs` or we keep `AggegateArgs` as
auxiliary structure?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
