milenkovicm commented on PR #10354: URL: https://github.com/apache/datafusion/pull/10354#issuecomment-2099975473
> The downside is that the user needs to both define `simplify` and set `has_simplify` to true, but I think it is much simpler than the optional closure I personally try to avoid situations like this when creating API, this should be documented that both functions have to be implemented plus it introduces more corner cases. Anyway, closure was a brain dump from yesterday, after a good sleep I don't think we need it, will try to elaborate in next comment -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
