viirya commented on code in PR #395: URL: https://github.com/apache/datafusion-comet/pull/395#discussion_r1594841342
########## common/src/main/java/org/apache/comet/parquet/ColumnReader.java: ########## @@ -207,6 +214,7 @@ public CometDecodedVector loadVector() { DictionaryEncoding dictionaryEncoding = vector.getField().getDictionary(); CometPlainVector cometVector = new CometPlainVector(vector, useDecimal128); + cometVector.setIsUuid(isUuid); Review Comment: Why not put it into constructor parameter list? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org