viirya commented on code in PR #395:
URL: https://github.com/apache/datafusion-comet/pull/395#discussion_r1602256624
##########
common/src/main/java/org/apache/comet/vector/CometPlainVector.java:
##########
@@ -111,7 +115,12 @@ public UTF8String getUTF8String(int rowId) {
byte[] result = new byte[length];
Platform.copyMemory(
null, valueBufferAddress + offset, result,
Platform.BYTE_ARRAY_OFFSET, length);
- return UTF8String.fromBytes(result);
+
+ if (!isUuid) {
+ return UTF8String.fromBytes(result);
+ } else {
+ return UTF8String.fromString(convertToUuid(result).toString());
+ }
Review Comment:
Hmm,
```
optional binary _13(ENUM);
```
I think we can specify physical type and logical type in the message, no?
For example, above line specifies `binary` as physical type and `ENUM` as
logical type.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
