comphead commented on code in PR #10427: URL: https://github.com/apache/datafusion/pull/10427#discussion_r1595577902
########## datafusion/expr/src/utils.rs: ########## @@ -885,7 +885,7 @@ pub fn can_hash(data_type: &DataType) -> bool { /// Check whether all columns are from the schema. pub fn check_all_columns_from_schema( columns: &HashSet<Column>, - schema: DFSchemaRef, + schema: &DFSchema, Review Comment: 👍 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org