comphead commented on code in PR #10427:
URL: https://github.com/apache/datafusion/pull/10427#discussion_r1595579395
##########
datafusion/expr/src/utils.rs:
##########
@@ -909,8 +909,8 @@ pub fn check_all_columns_from_schema(
pub fn find_valid_equijoin_key_pair(
left_key: &Expr,
right_key: &Expr,
- left_schema: DFSchemaRef,
- right_schema: DFSchemaRef,
+ left_schema: &DFSchema,
Review Comment:
thats interesting, should we a reference instead of Arc whenever possible?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
