b41sh commented on code in PR #10445:
URL: https://github.com/apache/datafusion/pull/10445#discussion_r1597413786
##########
datafusion/expr/src/logical_plan/builder.rs:
##########
@@ -188,37 +181,61 @@ impl LogicalPlanBuilder {
n_cols
);
}
- field_types = row
- .iter()
- .enumerate()
- .map(|(j, expr)| {
- if let Expr::Literal(ScalarValue::Null) = expr {
- nulls.push((i, j));
- Ok(field_types[j].clone())
- } else {
- let data_type = expr.get_type(&empty_schema)?;
- if let Some(prev_data_type) = &field_types[j] {
- if prev_data_type != &data_type {
- return plan_err!("Inconsistent data type
across values list at row {i} column {j}. Was {prev_data_type} but found
{data_type}")
+ }
+
+ let empty_schema = DFSchema::empty();
Review Comment:
Hi @alamb, long time no see, thanks for the review. Do you mean to move the
code for extracting the common types of values to `type_coercion.rs`? One
problem is that `optimizer` crate depends on `expr` crate and we can't call the
`optimizer` crate function in `LogicalPlanBuilder`. Maybe I'm not understanding
you correctly, please give more advice to help me understand.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
