alamb commented on PR #10466: URL: https://github.com/apache/datafusion/pull/10466#issuecomment-2107218784
Thanks @AbrarNitk ! I started the CI checks on this PR Normally I think we should add some test coverage so we don't accidentally break this in the future. This would I think this could take the form of: 1. (Ideally) find an example of wat 1. Add a doc example 2. Add a unit test However, in this case perhaps I think we could simply merge this PR and then use the code in https://github.com/apache/datafusion/pull/10460 with @ClSlaid Looks like the CI failed for running `rust fmt` https://github.com/apache/datafusion/actions/runs/9050685356/job/24892712284?pr=10466 Can you fix that and then we can get this PR merged? Thanks agian -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
