alamb commented on code in PR #10466:
URL: https://github.com/apache/datafusion/pull/10466#discussion_r1598470896
##########
datafusion/expr/src/logical_plan/builder.rs:
##########
@@ -1138,6 +1139,31 @@ impl LogicalPlanBuilder {
)?))
}
}
+
+/// Converts a `Arc<LogicalPlan>` into `LogicalPlanBuilder`
Review Comment:
FYI in general, the style of docs in Rust is to put them in triple quotes
which will ensure they are actually run as part of the CI tests (`cargo test
--doc` will run them)
So in this case like
```
/// ```
/// fn employee_schema() -> Schema {
...
```
Any chance you are willing to make a follow on PR to change this to a
docstring @AbrarNitk ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
