berkaysynnada opened a new pull request, #10504:
URL: https://github.com/apache/datafusion/pull/10504
## Which issue does this PR close?
<!--
We generally require a GitHub issue to be filed for all bug fixes and
enhancements and this helps us generate change logs for our releases. You can
link an issue to this PR using the GitHub syntax. For example `Closes #123`
indicates that this PR will close issue #123.
-->
Closes #9832.
## Rationale for this change
<!--
Why are you proposing this change? If this is already explained clearly in
the issue then this section is not needed.
Explaining clearly why changes are proposed helps reviewers understand your
changes and offer better suggestions for fixes.
-->
There exists a bug in `CastExpr` orderings, as detailed in the
[issue](https://github.com/apache/datafusion/issues/9832). To solve this
problem, we need to append `DataType` information of children in the
`get_ordering` method of `PhysicalExpr`'s. However, this problem can be solved
in a more clever way offering more functionality.
I propose to extend `get_ordering` method to `get_properties` such that it
can also carry the **range** information of expressions, which could have an
important meaning for expressions when investigating the order information.
Having range information would help `ScalarFunctionExpr`'s order
calculations since many of them have monotonicity pattern on some defined
intervals. I have also given an example of it for ABS() function.
## What changes are included in this PR?
<!--
There is no need to duplicate the description in the issue here but it is
sometimes worth providing a summary of the individual changes in this PR.
-->
1) Function monotonicity in scalar functions should not be set via a boolean
vector according to the effect of the parameter on function monotonicity.
Instead, it should be hardcoded in the function bodies since most of them have
their own monotonicity patterns, and they need to decide whether they are
ordered or not according to the its input properties.
(I have updated the existing monotonicity calculations and add some more,
but there are still TODO's)
2) To be able to use `ScalarFunctionExpr's` in interval arithmetic, we will
have also `evaluate_bounds()` and `propagate_constraints()` methods in
`ScalarUDF`.
3) Minor updates in interval_arithmetic.rs
- Storing unbounded unsigned integers as [0 - Null]
- Or support for boolean intervals
- Arithmetic negation of intervals
## Are these changes tested?
<!--
We typically require tests for all PRs in order to:
1. Prevent the code from being accidentally broken by subsequent changes
2. Serve as another way to document the expected behavior of the code
If tests are not included in your PR, please explain why (for example, are
they covered by existing tests)?
-->
Yes, in order.slt
## Are there any user-facing changes?
<!--
If there are user-facing changes then we may require documentation to be
updated before approving the PR.
-->
<!--
If there are any breaking changes to public APIs, please add the `api
change` label.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
