alamb commented on code in PR #10504:
URL: https://github.com/apache/datafusion/pull/10504#discussion_r1600576360
##########
datafusion/expr/src/udf.rs:
##########
@@ -202,18 +203,27 @@ impl ScalarUDF {
Arc::new(move |args| captured.invoke(args))
}
- /// This function specifies monotonicity behaviors for User defined scalar
functions.
- ///
- /// See [`ScalarUDFImpl::monotonicity`] for more details.
- pub fn monotonicity(&self) -> Result<Option<FuncMonotonicity>> {
- self.inner.monotonicity()
- }
-
/// Get the circuits of inner implementation
pub fn short_circuits(&self) -> bool {
self.inner.short_circuits()
}
+ pub fn evaluate_bounds(&self, input: &[&Interval]) -> Result<Interval> {
Review Comment:
If we want to add these new functions to the scalar function API I think
they need doc comments explaining what they do and how to use them
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
