advancedxy commented on code in PR #426:
URL: https://github.com/apache/datafusion-comet/pull/426#discussion_r1600319742
##########
spark/src/test/scala/org/apache/comet/CometCastSuite.scala:
##########
@@ -35,6 +35,9 @@ import org.apache.comet.expressions.{CometCast, Compatible}
class CometCastSuite extends CometTestBase with AdaptiveSparkPlanHelper {
import testImplicits._
+ /** Create a data generator using a fixed seed so that tests are
reproducible */
+ private val gen = new DataGenerator(new Random(42))
Review Comment:
I think it would be better to make this instance a field in the Companion
object of ~~Random~~DataGenerator?
So that other test suites can all use the same random data generator by
default.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
