andygrove commented on code in PR #426:
URL: https://github.com/apache/datafusion-comet/pull/426#discussion_r1600860138
##########
spark/src/test/scala/org/apache/comet/CometCastSuite.scala:
##########
@@ -35,7 +35,11 @@ import org.apache.comet.expressions.{CometCast, Compatible}
class CometCastSuite extends CometTestBase with AdaptiveSparkPlanHelper {
import testImplicits._
- private val dataSize = 1000
+ /** Create a data generator using a fixed seed so that tests are
reproducible */
+ private val gen = DataGenerator.DEFAULT
+
+ /** Number of random data items to generate in each test */
+ private val dataSize = 10000
Review Comment:
Yes. At 1000 I saw string -> short fail, but not the other string -> integer
tests. When I increased this to 10000 then all of the string -> integer tests
failed, so seems like we get better coverage at this level
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
