lewiszlw commented on PR #10506: URL: https://github.com/apache/datafusion/pull/10506#issuecomment-2111511903
> Thank you for this PR @lewiszlw -- I can't quite understand what it is fixing. Is there any way you can add a unit test to the round trip serialization tests that fails prior to the code change but passes afterwards? > > I think that would make it easier to understand what bug was fixed as well as ensure we don't accidentally break it again > > Somewere in https://github.com/apache/datafusion/blob/main/datafusion/proto/tests/proto_integration.rs perhaps? I updated desc and physical window plan proto test. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
