lewiszlw commented on code in PR #10506:
URL: https://github.com/apache/datafusion/pull/10506#discussion_r1600897119
##########
datafusion/proto/tests/cases/roundtrip_physical_plan.rs:
##########
@@ -253,8 +253,7 @@ fn roundtrip_nested_loop_join() -> Result<()> {
fn roundtrip_window() -> Result<()> {
let field_a = Field::new("a", DataType::Int64, false);
let field_b = Field::new("b", DataType::Int64, false);
- let field_c = Field::new("FIRST_VALUE(a) PARTITION BY [b] ORDER BY [a ASC
NULLS LAST] RANGE BETWEEN UNBOUNDED PRECEDING AND CURRENT ROW",
DataType::Int64, false);
- let schema = Arc::new(Schema::new(vec![field_a, field_b, field_c]));
+ let schema = Arc::new(Schema::new(vec![field_a, field_b]));
Review Comment:
this schema will be used as input schema, see line 310. I don't think the
input schema should contains window field.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
