erratic-pattern commented on code in PR #10386:
URL: https://github.com/apache/datafusion/pull/10386#discussion_r1600964827
##########
datafusion/optimizer/src/simplify_expressions/expr_simplifier.rs:
##########
@@ -447,12 +435,11 @@ impl TreeNodeRewriter for Canonicalizer {
}
}
-#[allow(rustdoc::private_intra_doc_links)]
/// Partially evaluate `Expr`s so constant subtrees are evaluated at plan time.
///
/// Note it does not handle algebraic rewrites such as `(a or false)`
/// --> `a`, which is handled by [`Simplifier`]
-struct ConstEvaluator<'a> {
+pub struct ConstEvaluator<'a> {
Review Comment:
`pub` so the doc example can run
##########
datafusion/optimizer/src/simplify_expressions/expr_simplifier.rs:
##########
@@ -472,9 +459,8 @@ struct ConstEvaluator<'a> {
input_batch: RecordBatch,
}
-#[allow(dead_code)]
/// The simplify result of ConstEvaluator
-enum ConstSimplifyResult {
+pub enum ConstSimplifyResult {
Review Comment:
`pub` so the doc example can run
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
