erratic-pattern commented on PR #10386: URL: https://github.com/apache/datafusion/pull/10386#issuecomment-2111619964
Alright I think this is in a good state now. I added a dynamic dispatch API which I think could be useful if we ever add `TreeNodeRewriter` impl for `OptimizerRule`, then we could run the whole optimizer through this cycle logic. I made some stuff public for doctests, but if we don't want to do that I can just mark the doctest as ignored -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
