tshauck opened a new pull request, #449:
URL: https://github.com/apache/datafusion-comet/pull/449

   ## Which issue does this PR close?
   
   Related to https://github.com/apache/datafusion-comet/issues/341.
   
   ## Rationale for this change
   
   I recently added `unhex` so this PR adds `hex`. It's another scalar function 
that isn't yet implemented in Comet.
   
   I decided to do a native version here because datafusion has an `to_hex`, 
but it has different functionality. E.g. `to_hex(-1)` returns 
`ffffffffffffffff` vs `hex(-1)` returning `FFFFFFFFFFFFFFFF`. Spark `hex` also 
supports strings, but datafusion and postgres do not. I'm happy to start the 
discussion if it seems it could be merged upstream.
   
   ## What changes are included in this PR?
   
   I added the `hex` scalar function.
   
   ## How are these changes tested?
   
   Yes, I've added tests to the rust side as well as spark sql based tests in 
scala.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org

Reply via email to