tshauck commented on code in PR #449:
URL: https://github.com/apache/datafusion-comet/pull/449#discussion_r1608584669
##########
spark/src/test/scala/org/apache/comet/CometExpressionSuite.scala:
##########
@@ -1038,6 +1038,46 @@ class CometExpressionSuite extends CometTestBase with
AdaptiveSparkPlanHelper {
}
}
}
+ test("hex") {
+ val str_table = "string_hex_table"
+ withTable(str_table) {
Review Comment:
Thanks for the feedback. I update the tests in
https://github.com/apache/datafusion-comet/pull/449/commits/2bfcf25a6705ec47d857670c65dbba979ca10e23
to use `makeParquetFileAllTypes`. And with a couple of changes its tests
passes w/ the ints, uint32 and uint64[1], and columns _8 and _14 which I think
are string/binary types.
When the #451 goes in, I'll look at updating the tests to add it too.
[1]: I'm a bit confused because it looks like every int crossing into rust
does so as an i64, which means rather than properly return say `FF` for u8, I'm
returning `FFFFFFFFFFFFFFFF`. I need to look into this further.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
