viirya commented on code in PR #10304:
URL: https://github.com/apache/datafusion/pull/10304#discussion_r1606948252
##########
datafusion/physical-plan/src/joins/sort_merge_join.rs:
##########
@@ -989,8 +996,21 @@ impl SMJStream {
}
}
Ordering::Equal => {
- if matches!(self.join_type, JoinType::LeftSemi) {
+ if matches!(self.join_type, JoinType::LeftSemi) &&
self.filter.is_some() {
+ join_streamed = !self
+ .streamed_batch
+ .join_filter_matched_idxs
+ .contains(&(self.streamed_batch.idx as u64))
+ && !self.streamed_joined;
Review Comment:
Oh, I got what you want to do here. It is better to add a comment for later
readers.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
