viirya commented on code in PR #437:
URL: https://github.com/apache/datafusion-comet/pull/437#discussion_r1608831021
##########
spark/src/main/scala/org/apache/comet/serde/QueryPlanSerde.scala:
##########
@@ -2417,11 +2417,12 @@ object QueryPlanSerde extends Logging with
ShimQueryPlanSerde with CometExprShim
return None
}
- if (join.buildSide == BuildRight) {
- // DataFusion HashJoin assumes build side is always left.
- // TODO: support BuildRight
- withInfo(join, "BuildRight is not supported")
- return None
+ join match {
+ case b: BroadcastHashJoinExec if b.isNullAwareAntiJoin =>
+ // DataFusion HashJoin LeftAnti has bugs on null keys.
+ withInfo(join, "DataFusion doesn't support null-aware anti join")
+ return None
+ case _ => // no-op
Review Comment:
https://github.com/apache/datafusion-comet/issues/457
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
