timsaucer commented on issue #6747: URL: https://github.com/apache/datafusion/issues/6747#issuecomment-2124691067
The one thing I think we're missing is the other variants for these. I don't think it's covered in other unit tests that I can find. So for example, for lead we would want to validate: - that setting a different shift offset works as expected - That setting no shift offset default works (this can be the basic test) - Setting no default value gives nulls - With and without partition_by - Testing with and without order_by (required by some window functions, so only test with) - Testing with and without null treatment - I'm not sure which of the functions this impacts - Testing with and without window frames What do you think? I might try to write a macro around all these variants. I'm now unblocked on the other task I was working on, so I can pick it up if you'd like or I'm happy to work on other things. Please let me know. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
