andygrove commented on code in PR #456:
URL: https://github.com/apache/datafusion-comet/pull/456#discussion_r1610434498
##########
spark/src/test/scala/org/apache/comet/exec/CometAggregateSuite.scala:
##########
@@ -1212,6 +1212,157 @@ class CometAggregateSuite extends CometTestBase with
AdaptiveSparkPlanHelper {
}
}
+ test("correlation") {
+ withSQLConf(CometConf.COMET_EXEC_SHUFFLE_ENABLED.key -> "true") {
+ Seq(false).foreach { cometColumnShuffleEnabled =>
Review Comment:
Is it intentional that we only test for `cometColumnShuffleEnabled==false`?
I have similar questions for `parquet.enable.dictionary` and
`nullOnDivideByZero`, where we also iterate over a single boolean and don't
test both for true and false.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
