huaxingao commented on code in PR #456: URL: https://github.com/apache/datafusion-comet/pull/456#discussion_r1610574040
########## spark/src/test/scala/org/apache/comet/exec/CometAggregateSuite.scala: ########## @@ -1212,6 +1212,157 @@ class CometAggregateSuite extends CometTestBase with AdaptiveSparkPlanHelper { } } + test("correlation") { + withSQLConf(CometConf.COMET_EXEC_SHUFFLE_ENABLED.key -> "true") { + Seq(false).foreach { cometColumnShuffleEnabled => Review Comment: Should be both `true` and `false`. I removed one of them so it's easier for me to debug. Forgot to put back. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org