davisp commented on PR #10590: URL: https://github.com/apache/datafusion/pull/10590#issuecomment-2125922609
@alamb I've updated things to use `METADTA(foo='bar')` though I'm not 100% on whether I've done it acceptably as I've basically only just allowed the use of `METADATA` in place of `OPTIONS` while not preventing the use of `OPTIONS`. Though given it was previously accepted (and ignored) I'd think that's not a big deal? If we only document `METADATA` the fact that `OPTIONS` works seems not super important. If you think that's a bit loosey goosey we could probably drop that `OPTIONS` version on the floor [here](https://github.com/apache/datafusion/blob/7bd4b53ffa12589340e4d7b4cf70df11f3403865/datafusion/sql/src/parser.rs#L669). @ozankabak I'm not entirely sure what you're asking to survey. Do you mean looking at various SQL dialects or various datafusion projects that are implementing `TableProvider`? For SQL dialects, I won't claim to have extensive knowledge on the various dialects, but based on my reading of the sqlparser source, this seems specific to the BigQuery dialect. However, there is a [ColumnOption::DialectSpecific](https://docs.rs/sqlparser/0.46.0/sqlparser/ast/enum.ColumnOption.html#variant.DialectSpecific) so that might be something to investigate? As for the "how do `TableProvider` implementations deal with it, I'd assume most folks are just doing the `OPTIONS("option::column.nested.whatever" "value")` like is done for the Parquet compression option? At the end of the day we're constrained by the Arrow Field::metadata being a `HashMap<String, String>` so I'm not sure how far to go looking on that front. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
