kazuyukitanimura commented on code in PR #449:
URL: https://github.com/apache/datafusion-comet/pull/449#discussion_r1613963307
##########
spark/src/test/scala/org/apache/comet/CometExpressionSuite.scala:
##########
@@ -1038,6 +1038,20 @@ class CometExpressionSuite extends CometTestBase with
AdaptiveSparkPlanHelper {
}
}
}
+ test("hex") {
+ Seq(true, false).foreach { dictionaryEnabled =>
+ withTempDir { dir =>
+ val path = new Path(dir.toURI.toString, "hex.parquet")
+ makeParquetFileAllTypes(path, dictionaryEnabled = dictionaryEnabled,
10000)
+
+ withParquetTable(path.toString, "tbl") {
+ // _9 and _10 (uint8 and uint16) not supported
+ checkSparkAnswerAndOperator(
+ "SELECT hex(_1), hex(_2), hex(_3), hex(_4), hex(_5), hex(_6),
hex(_7), hex(_8), hex(_11), hex(_12), hex(_13), hex(_14), hex(_15), hex(_16),
hex(_17), hex(_18), hex(_19), hex(_20) FROM tbl")
Review Comment:
We have several scalar tests i.e. `ceil and floor`, `scalar decimal
arithmetic operations`, etc. I agree that the existing coverage is not great.
Since you have the code to handle scalar, it is best to test them. Or it is
also okay to disable scalar for now and put it as TODO.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
