goldmedal commented on PR #10661: URL: https://github.com/apache/datafusion/pull/10661#issuecomment-2132256147
I think I got it now. In #10644, `MEDIAN` was removed from the AggregationFunction list and reimplemented as a UDAF. It looks like the list of aggregation functions handles some name mapping for case insensitivity. See: https://github.com/apache/datafusion/blob/52c4f3cce68afc45f25599b3917e06f0c6b63192/datafusion/expr/src/aggregate_function.rs#L117 https://github.com/apache/datafusion/blob/52c4f3cce68afc45f25599b3917e06f0c6b63192/datafusion/expr/src/aggregate_function.rs#L171 That's why we don't need to add a lowercase alias for `FIRST_VALUE` in `first_last.rs`. It seems `FIRST_VALUE` has been redesigned as a UDAF but hasn't been removed from the AggregationFunction list. I'm not sure if this is an issue. I reverted the change for `median` and removed the name testing for case insensitivity. However, I think adding a lowercase alias for `MEDIAN` is a workaround to handle the function name case insensitivity issue for UDAF. Maybe we need a formal way to handle this, but I'm not sure. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
