jayzhan211 commented on PR #10661: URL: https://github.com/apache/datafusion/pull/10661#issuecomment-2132459487
> That's why we don't need to add a lowercase alias for `FIRST_VALUE` in `first_last.rs`. It seems `FIRST_VALUE` has been redesigned as a UDAF but hasn't been removed from the AggregationFunction list. I'm not sure if this is an issue. `first_value` is not added in alias because the function is not fully converted to UDAF yet, so it will fail some tests. #10648 has alias for lower case so as `approx_median` since it is not UDAF yet. > I think adding a lowercase alias for MEDIAN is a workaround to handle the function name case insensitivity issue for UDAF Why adding a lowercase alias is a workaround for UDAF? Without alias, we will need to check the lowercase in many places. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
