waynexia commented on code in PR #10646:
URL: https://github.com/apache/datafusion/pull/10646#discussion_r1617168485
##########
datafusion/substrait/src/logical_plan/consumer.rs:
##########
@@ -1160,6 +1162,24 @@ pub(crate) fn from_substrait_type(dt:
&substrait::proto::Type) -> Result<DataTyp
"Unsupported Substrait type variation {v} of type
{s_kind:?}"
),
},
+ r#type::Kind::UserDefined(u) => {
+ match u.type_reference {
+ INTERVAL_YEAR_MONTH_TYPE_REF => {
Review Comment:
There are two "references":
https://github.com/apache/datafusion/pull/10646/files#diff-d1c5f4c37ac8286d2045acb61bee17382179469557132eb02844413b260ae41bR1440-R1441
To my understanding, type variation (like
[these](https://github.com/apache/datafusion/pull/10646/files#diff-c7934d272ebcb8a37036a33903e38204a4448dc35f31fea712b4ba9086c12c42R29-R40))
are for different types from *one base type*. And type references (like
[these](https://github.com/apache/datafusion/pull/10646/files#diff-c7934d272ebcb8a37036a33903e38204a4448dc35f31fea712b4ba9086c12c42R42-R78))
are for different base types, those user-defined types.
I'll submit a patch to add document for the usage tomorrow.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
