waynexia commented on code in PR #10646:
URL: https://github.com/apache/datafusion/pull/10646#discussion_r1618465409
##########
datafusion/substrait/src/logical_plan/consumer.rs:
##########
@@ -1160,6 +1162,24 @@ pub(crate) fn from_substrait_type(dt:
&substrait::proto::Type) -> Result<DataTyp
"Unsupported Substrait type variation {v} of type
{s_kind:?}"
),
},
+ r#type::Kind::UserDefined(u) => {
+ match u.type_reference {
+ INTERVAL_YEAR_MONTH_TYPE_REF => {
Review Comment:
>I believe both should be defined as SimpleExtension files
Yes, that's right. The last (I'm aware of, at least) big piece we are
missing in substrait is those *.yaml spec for all extended things and related
URL settings. At present, all the things are defined in the document.
From the substrait [website](substrait.io), we'll need a yaml parsing
component to support extensions from other systems as well, if we are going to
implement the ability to consume plans from external systems.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
