alamb commented on code in PR #10702: URL: https://github.com/apache/datafusion/pull/10702#discussion_r1618607123
########## datafusion/core/src/physical_optimizer/join_selection.rs: ########## @@ -157,7 +157,9 @@ fn swap_join_projection( } /// This function swaps the inputs of the given join operator. -fn swap_hash_join( +/// This function is public so other downstream projects can use it +/// to construct `HashJoinExec` with right side as the build side. +pub fn swap_hash_join( Review Comment: Given this input takes `&HashJoinExec` as input, it seems like it might be easier to find / make more sense as a method on `HashJoinExec` itself 🤔 So maybe we could update the code so this function is `HashJoinExec::swap_inputs` or something -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
