viirya commented on code in PR #10702: URL: https://github.com/apache/datafusion/pull/10702#discussion_r1619347294
########## datafusion/core/src/physical_optimizer/join_selection.rs: ########## @@ -157,7 +157,9 @@ fn swap_join_projection( } /// This function swaps the inputs of the given join operator. -fn swap_hash_join( +/// This function is public so other downstream projects can use it Review Comment: Without a clear comment, it might be wrongly moved out of public APIs easily. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
