comphead commented on code in PR #10724:
URL: https://github.com/apache/datafusion/pull/10724#discussion_r1622591281
##########
datafusion/physical-plan/src/joins/sort_merge_join.rs:
##########
@@ -1181,7 +1189,10 @@ impl SMJStream {
let filter_columns = if chunk.buffered_batch_idx.is_some() {
if matches!(self.join_type, JoinType::Right) {
get_filter_column(&self.filter, &buffered_columns,
&streamed_columns)
- } else if matches!(self.join_type, JoinType::LeftSemi) {
+ } else if matches!(
Review Comment:
I have a separate ticket for Right* joins, however I'm not sure how to build
a right join on the sql level tbh. I will check it once we have Left* stabilized
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
