comphead commented on PR #10724: URL: https://github.com/apache/datafusion/pull/10724#issuecomment-2142522365
> Thank you @comphead -- this looks like an improvement to me. Queries now get correct answers that did not before. > > I remember that Anti join semantics are quite subtle, and I am not sure I would catch subtle bugs in my review, but it seems to me that this code is an improvement to what is on main > > nice work Thanks @alamb I have added the basic left anti join test cases to slt file. However once we resolve the https://github.com/apache/datafusion/issues/10659 it gonna be easier to find issues then we cannot imagine right away -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
