viirya commented on code in PR #506:
URL: https://github.com/apache/datafusion-comet/pull/506#discussion_r1625009061
##########
core/src/execution/datafusion/planner.rs:
##########
@@ -1397,7 +1397,18 @@ impl PhysicalPlanner {
args.is_empty(),
));
- Ok(scalar_expr)
+ match fun_name.as_str() {
Review Comment:
Hmm, please don't put this special handling in
`create_scalar_function_expr`. Could you move it to `create_comet_physical_fun`
where special handling of scalar functions should be located?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
