PedroMDuarte commented on code in PR #506:
URL: https://github.com/apache/datafusion-comet/pull/506#discussion_r1625042666
##########
core/src/execution/datafusion/planner.rs:
##########
@@ -1397,7 +1397,18 @@ impl PhysicalPlanner {
args.is_empty(),
));
- Ok(scalar_expr)
+ match fun_name.as_str() {
Review Comment:
Thanks for bringing that up!
Just to clarify, if we were to do this as part of
`create_comet_physical_fun` then it would be all reimplemented at a lower level
and not able to reuse the Datafusion Log2 implementation via an IfExpr. Is
that right?
Happy to go either way. @andygrove's original hint mentioned using IfExpr,
but I couldn't quite get that working inside of `create_comet_physical_fun`
because it doesn't have access to the arg exprs.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
