andygrove opened a new issue, #10805:
URL: https://github.com/apache/datafusion/issues/10805

   ### Is your feature request related to a problem or challenge?
   
   In downstream crates such as Comet, we don't have a good way to catch 
overflow errors from DataFusion/Arrow. We have to rely on looking for certain 
words in error messages. For example:
   
   ```rust
   match self.inner_abs_func.invoke(args) {
       Ok(result) => Ok(result),
       Err(DataFusionError::ArrowError(ArrowError::ComputeError(msg), trace)) 
if msg.contains("overflow") => { ... }
   ```
   
   We then create a specific overflow exception:
   
   ```rust
   CometError::ArithmeticOverflow {
       from_type: from_type.to_string(),
   }
   ```
   
   ### Describe the solution you'd like
   
   It would be a better developer experience if DataFusion/Arrow had specific 
overflow errors. I see that Arrow already has `DivideByZero` so it seems 
logical that we could also have an `Overflow` or `ArithmeticOverflow` as well. 
I will file an issue in Arrow and link to it from this issue.
   
   ### Describe alternatives you've considered
   
   _No response_
   
   ### Additional context
   
   _No response_


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to