alamb commented on code in PR #10738: URL: https://github.com/apache/datafusion/pull/10738#discussion_r1628066780
########## datafusion/core/src/datasource/physical_plan/parquet/row_groups.rs: ########## @@ -36,58 +36,34 @@ use crate::datasource::physical_plan::parquet::statistics::{ }; use crate::physical_optimizer::pruning::{PruningPredicate, PruningStatistics}; -use super::ParquetFileMetrics; +use super::{ParquetAccessPlan, ParquetFileMetrics}; -/// Tracks which RowGroups within a parquet file should be scanned. +/// Calculates which RowGroups within a parquet file should be scanned. /// -/// This struct encapsulates the various types of pruning that can be applied to +/// This struct implements the various types of pruning that are applied to /// a set of row groups within a parquet file, progressively narrowing down the /// set of row groups that should be scanned. -#[derive(Debug, PartialEq)] -pub struct RowGroupSet { - /// `row_groups[i]` is true if the i-th row group should be scanned - row_groups: Vec<bool>, +#[derive(Debug, Clone, PartialEq)] +pub struct RowGroupPlanBuilder { Review Comment: Renamed in 52f4d39d13a096f0986095c637500b988ad2004c -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org