alamb commented on code in PR #10738:
URL: https://github.com/apache/datafusion/pull/10738#discussion_r1629349375
##########
datafusion/core/src/datasource/physical_plan/parquet/access_plan.rs:
##########
@@ -170,6 +170,12 @@ impl ParquetAccessPlan {
/// The returned selection represents which rows to scan across any row
/// row groups which are not skipped.
///
+ /// # Notes
+ ///
+ /// If there are no [`RowGroupAccess::Selection`]s, the overall row
+ /// selection is `None` because each row group is either entirely skipped
or
+ /// scanned, as specified by [`Self::row_group_indexes`].
Review Comment:
Excellent idea - I added more comments and examples in a76f95a1e. Thank you
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
