andygrove commented on code in PR #509:
URL: https://github.com/apache/datafusion-comet/pull/509#discussion_r1628131201
##########
spark/src/main/scala/org/apache/comet/serde/QueryPlanSerde.scala:
##########
@@ -578,6 +576,14 @@ object QueryPlanSerde extends Logging with
ShimQueryPlanSerde with CometExprShim
}
}
+ def evalModeToProto(evalMode: CometEvalMode.Value): ExprOuterClass.EvalMode
= {
+ evalMode match {
+ case CometEvalMode.LEGACY => ExprOuterClass.EvalMode.LEGACY
+ case CometEvalMode.TRY => ExprOuterClass.EvalMode.TRY
+ case CometEvalMode.ANSI => ExprOuterClass.EvalMode.ANSI
Review Comment:
Good point. I have added this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
