kazuyukitanimura commented on code in PR #509:
URL: https://github.com/apache/datafusion-comet/pull/509#discussion_r1628199998
##########
spark/src/main/scala/org/apache/comet/CometSparkSessionExtensions.scala:
##########
@@ -712,17 +712,6 @@ class CometSparkSessionExtensions
}
override def apply(plan: SparkPlan): SparkPlan = {
- // DataFusion doesn't have ANSI mode. For now we just disable CometExec
if ANSI mode is
- // enabled.
- if (isANSIEnabled(conf)) {
- if (COMET_ANSI_MODE_ENABLED.get()) {
- logWarning("Using Comet's experimental support for ANSI mode.")
- } else {
- logInfo("Comet extension disabled for ANSI mode")
- return plan
- }
- }
Review Comment:
For Spark 3.x, I feel we still need this protection in case users enable
ANSI mode as well as native execution.
If I understand correctly we have not set up CI yet with ANSI enabled.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
