Blizzara commented on issue #10815:
URL: https://github.com/apache/datafusion/issues/10815#issuecomment-2158666881
Hmm not sure how you got the NotImplemented error - maybe somehow running a
quite old DataFusion? However with the query
>
> ```
> SELECT p1.PS_PARTKEY supp_key, p2.PS_PARTKEY cust_key
> FROM
> 'partsupp' p1,
> 'partsupp' p2
> ```
I do get the same error as you originally:
```
#[tokio::test]
async fn roundtrip_implicit_cross_join() -> Result<()> {
roundtrip("SELECT p1.a p1_a, p2.a p2_a FROM data p1, data p2").await
}
Error: Plan("Projections require unique expression names but the expression
\"data.a\" at position 0 and \"data.a\" at position 1 have the same name.
Consider aliasing (\"AS\") one of them.")
```
This is because Substrait doesn't include aliases neither for tables nor for
columns. I'm trying to see if I can add that into Substrait, it'd make these
things easier to support: https://github.com/substrait-io/substrait/pull/648
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
