Blizzara commented on code in PR #10874:
URL: https://github.com/apache/datafusion/pull/10874#discussion_r1635258871
##########
datafusion/common/src/utils/mod.rs:
##########
@@ -354,7 +354,7 @@ pub fn longest_consecutive_prefix<T: Borrow<usize>>(
pub fn array_into_list_array(arr: ArrayRef) -> ListArray {
let offsets = OffsetBuffer::from_lengths([arr.len()]);
ListArray::new(
- Arc::new(Field::new("item", arr.data_type().to_owned(), true)),
+ Arc::new(Field::new_list_field(arr.data_type().to_owned(), true)),
Review Comment:
this is no-op change, just seems nicer to use the new_list_field given it
exists (it sets the name as "item" anyways)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
