Blizzara commented on code in PR #10874:
URL: https://github.com/apache/datafusion/pull/10874#discussion_r1635380670
##########
datafusion/substrait/src/logical_plan/producer.rs:
##########
@@ -2309,14 +2309,12 @@ mod test {
round_trip_type(DataType::Decimal128(10, 2))?;
round_trip_type(DataType::Decimal256(30, 2))?;
- for nullable in [true, false] {
- round_trip_type(DataType::List(
- Field::new_list_field(DataType::Int32, nullable).into(),
- ))?;
- round_trip_type(DataType::LargeList(
- Field::new_list_field(DataType::Int32, nullable).into(),
- ))?;
- }
+ round_trip_type(DataType::List(
Review Comment:
I don't think we need to test the null coercion specifically, since that's
not necessarily the ultimate desired behavior, just what makes sense at this
time. But I added a test case to confirm that we can now read plans with
non-nullable lists:
https://github.com/apache/datafusion/pull/10874/commits/a25abd89a5547182193caee68a7c6f458f4b1d23
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
