andygrove commented on PR #558:
URL: https://github.com/apache/datafusion-comet/pull/558#issuecomment-2161760028
> Is that really 839 `nano`seconds versus 68 `pico`seconds or am I
interpreting the units incorrectly?
Yes, it really is. Here is the criterion code for displaying the time units.
```rust
pub fn time(ns: f64) -> String {
if ns < 1.0 {
format!("{:>6} ps", short(ns * 1e3))
} else if ns < 10f64.powi(3) {
format!("{:>6} ns", short(ns))
} else if ns < 10f64.powi(6) {
format!("{:>6} µs", short(ns / 1e3))
} else if ns < 10f64.powi(9) {
format!("{:>6} ms", short(ns / 1e6))
} else {
format!("{:>6} s", short(ns / 1e9))
}
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
