andygrove commented on PR #558:
URL: https://github.com/apache/datafusion-comet/pull/558#issuecomment-2161776154

   > Is that really 839 `nano`seconds versus 68 `pico`seconds or am I 
interpreting the units incorrectly?
   
   I am questioning the earlier results now. Latest benchmark comparing safe 
version of `decode_i32_to_u16` vs unsafe version of `decode_i32_to_i16`. Now 
seeing 67 ns not 68 ps. Curious.
   
   ```
   parquet_decode/decode_i32_to_i16
                           time:   [66.709 ns 67.213 ns 67.711 ns]
                           change: [-2.4520% -1.0484% +0.3895%] (p = 0.15 > 
0.05)
                           No change in performance detected.
   parquet_decode/decode_i32_to_u16
                           time:   [589.31 ns 590.62 ns 592.21 ns]
   Found 3 outliers among 100 measurements (3.00%)
     2 (2.00%) high mild
     1 (1.00%) high severe
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org

Reply via email to